Review Request 111097: Use KTp::ContactGridDialog for Contact applet configuration

[Dan Vrátil]

> On June 18, 2013, 4:43 p.m., David Edmundson wrote:
> > contact/src/telepathy-contact.cpp, line 233
> > <http://git.reviewboard.kde.org/r/111097/diff/1/?file=164219#file164219line233>
> >
> >     Is this needed?
> >     
> >     If so that means the filter is broken.

Leftover from testing. Filters work correctly without invalidate() as well.


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111097/#review34587
-----------------------------------------------------------


On June 18, 2013, 4:34 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111097/
> -----------------------------------------------------------
> 
> (Updated June 18, 2013, 4:34 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Use Ktp::ContactGridDialog instead of own UI, since the grid is known to work and is sort of standard UI for contact selection in KTp.
> 
> The main advantage of of ContactGridDialog is that it has a search field, which is I think more useful than 'show online/offline' toggle, since you usually know who you want to add to the applet when you are configuring it, so you will more probably just want to type contact's name and click, instead of scrolling through a list and strcmp()'ing contact names in head :-)
> 
> 
> Diffs
> -----
> 
>   contact/CMakeLists.txt a94a864 
>   contact/src/applet_config.h 772b7cf 
>   contact/src/applet_config.cpp 52fff50 
>   contact/src/applet_config.ui 1b51c46 
>   contact/src/telepathy-contact.h 6d4505f 
>   contact/src/telepathy-contact.cpp 9db8217 
> 
> Diff: http://git.reviewboard.kde.org/r/111097/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130618/032d8711/attachment.html>