Review Request 111095: Make it possible to send email from contact applet even when contact is offline

[David Edmundson]

> On June 18, 2013, 2:24 p.m., David Edmundson wrote:
> > contact/src/declarative/contents/ui/Contact.qml, line 49
> > <http://git.reviewboard.kde.org/r/111095/diff/1/?file=164175#file164175line49>
> >
> >     what does this have to do with avatars?
> >     
> >     This seems like a bad property name, or I'm missing something.
> 
> Dan Vrátil wrote:
>     I just copy-pasted it from Avatar :-)

I've never seen Avatar :(


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111095/#review34585
-----------------------------------------------------------


On June 18, 2013, 5:08 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111095/
> -----------------------------------------------------------
> 
> (Updated June 18, 2013, 5:08 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Slightly changes behavior of the applet: the avatar is always clickable, but the individual actions are enabled only when online (except for the "send mail" action, which is enabled all the time)
> 
> 
> This addresses bug 294104.
>     http://bugs.kde.org/show_bug.cgi?id=294104
> 
> 
> Diffs
> -----
> 
>   contact/src/declarative/contents/ui/Avatar.qml f716e7e 
>   contact/src/declarative/contents/ui/Contact.qml 9b4e8df 
>   contact/src/declarative/contents/ui/DropDownMenu.qml fc59949 
> 
> Diff: http://git.reviewboard.kde.org/r/111095/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130618/c20cfaee/attachment.html>