Review Request 111088: [logviewer] Show a message when no logs are available for given contact or day
Commit Hook
null at kde.org
Tue Jun 18 16:31:31 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111088/#review34593
-----------------------------------------------------------
This review has been submitted with commit 452b06f4896222bca38987280359b7a4cad02969 by Dan Vrátil to branch master.
- Commit Hook
On June 18, 2013, 11:49 a.m., Dan Vrátil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111088/
> -----------------------------------------------------------
>
> (Updated June 18, 2013, 11:49 a.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Shows a label saying "There are no logs for this day" or "There are no logs for this contact" when user selects a date without logs or starts logviewer with ID of a contact for which we have no logs.
>
> The QLabel feels a bit hackish, but with Adium I don't see any other way. We can do this properly once QML viewer is in place.
>
>
> This addresses bug 316487.
> http://bugs.kde.org/show_bug.cgi?id=316487
>
>
> Diffs
> -----
>
> logviewer/entity-view.h d55f194
> logviewer/entity-view.cpp 69c408f
> logviewer/log-viewer.h 9341064
> logviewer/log-viewer.cpp 743cda4
> logviewer/message-view.h c9ae322
> logviewer/message-view.cpp 96ad846
>
> Diff: http://git.reviewboard.kde.org/r/111088/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
>
> http://git.reviewboard.kde.org/media/uploaded/files/2013/06/18/logviewer.png
>
>
> Thanks,
>
> Dan Vrátil
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130618/b73e84cd/attachment.html>
More information about the KDE-Telepathy
mailing list