Review Request 111091: Add "Always Ask" option for filetransfer destination directory

Dan Vrátil dvratil at redhat.com
Tue Jun 18 13:37:30 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111091/
-----------------------------------------------------------

Review request for Telepathy.


Description
-------

Implements support for "Always Ask" for filetransfer destination directory option.

The hack with __k__onDownloadDirectoryCancelled() is necessary because KDirSelectDialog::result() always returns 0 and buttonClicked() signal is emitted even when "New Folder" button is clicked and handling that would make the code more complicated.


This addresses bug 295937.
    http://bugs.kde.org/show_bug.cgi?id=295937


Diffs
-----

  src/CMakeLists.txt ebd892c 
  src/filetransfer-handler.cpp 74c701e 
  src/handle-incoming-file-transfer-channel-job.h d5e53c4 
  src/handle-incoming-file-transfer-channel-job.cpp 7a15237 

Diff: http://git.reviewboard.kde.org/r/111091/diff/


Testing
-------


Thanks,

Dan Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130618/f4513881/attachment.html>


More information about the KDE-Telepathy mailing list