Review Request 111077: Move the contact list back up when the contact list filtering changes

[Aleix Pol Gonzalez]

> On June 17, 2013, 6:28 p.m., David Edmundson wrote:
> > This looks more like a hack round someone else's bug than a fix...
> > 
> > (plus one to removing that Binding{} code though)
> 
> David Edmundson wrote:
>     I owe you a better review.
>     
>     My (entirely made up) rules on hacking round a bug fix are:
>      1) It should be a last resort (i.e after at least trying to fix Plasma. if that's difficult to fix or we want to make a release now then we can add a hack)
>      2) It needs to have a comment explaining what and why, and ideally linking to a bug report. 
>

You know what, I'm getting a bit tired of thinking about ScrollBar+Flickable. They are broken whenever things change size.

I need to think about the problem further and I'm not very interested in doing it for QtQuick1. Let's all hack KF5 and forget about Qt4.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111077/#review34513
-----------------------------------------------------------


On June 17, 2013, 9:50 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111077/
> -----------------------------------------------------------
> 
> (Updated June 17, 2013, 9:50 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> It moves the list up when the filtering changes. I'm unsure if the bug here is the scrollbar as in the ChatWidget, but it seems to help. What was happening was that when you filter you get a big blank space between the filter and the results.
> 
> 
> Diffs
> -----
> 
>   contactlist/org.kde.ktp-contactlist/contents/ui/ContactList.qml 8f82f75 
> 
> Diff: http://git.reviewboard.kde.org/r/111077/diff/
> 
> 
> Testing
> -------
> 
> just launched plasma with it, it seemed less broken.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130617/a7eaf36a/attachment-0001.html>