Review Request 111077: Move the contact list back up when the contact list filtering changes

David Edmundson david at davidedmundson.co.uk
Mon Jun 17 18:28:51 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111077/#review34513
-----------------------------------------------------------


This looks more like a hack round someone else's bug than a fix...

(plus one to removing that Binding{} code though)

- David Edmundson


On June 17, 2013, 6:20 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111077/
> -----------------------------------------------------------
> 
> (Updated June 17, 2013, 6:20 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> It moves the list up when the filtering changes. I'm unsure if the bug here is the scrollbar as in the ChatWidget, but it seems to help. What was happening was that when you filter you get a big blank space between the filter and the results.
> 
> 
> Diffs
> -----
> 
>   contactlist/org.kde.ktp-contactlist/contents/ui/ContactList.qml 8f82f75 
> 
> Diff: http://git.reviewboard.kde.org/r/111077/diff/
> 
> 
> Testing
> -------
> 
> just launched plasma with it, it seemed less broken.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130617/db5e653f/attachment.html>


More information about the KDE-Telepathy mailing list