Review Request 110948: Fix hovering the delegate button
David Edmundson
david at davidedmundson.co.uk
Tue Jun 11 08:51:15 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110948/#review34111
-----------------------------------------------------------
Ship it!
Ship It!
- David Edmundson
On June 11, 2013, 12:02 a.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110948/
> -----------------------------------------------------------
>
> (Updated June 11, 2013, 12:02 a.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> This patch solves/workarounds a bug with PlasmaCore.ToolTip that would make it not to forward properly the hover event to the button thus not making it render properly on hover.
>
> I searched through the code and I saw that most people were using it on a MouseArea and it does seem to solve the problem.
> The whole concept of how these ToolTip work seem broken to me so I don't think it's worth fixing or figuring further.
>
>
> Diffs
> -----
>
> chat/org.kde.ktp-chat/contents/ui/ConversationDelegateButton.qml 619b19a
>
> Diff: http://git.reviewboard.kde.org/r/110948/diff/
>
>
> Testing
> -------
>
> It looks nice when hovering the plasmoid now.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130611/10c15573/attachment.html>
More information about the KDE-Telepathy
mailing list