Review Request 110935: Add sso-google support

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110935/#review34049
-----------------------------------------------------------

Ship it!



sasl-auth-op.cpp
<http://git.reviewboard.kde.org/r/110935/#comment25037>

    Yes, just move these 3 lines to above the #ifdef and delete in the four places.
    
    That still leaves the onSASLStatusChanged() but that's not a big problem



x-telepathy-sso-google-operation.cpp
<http://git.reviewboard.kde.org/r/110935/#comment25035>

    LGPL please (header file too)


- David Edmundson


On June 10, 2013, 2:57 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110935/
> -----------------------------------------------------------
> 
> (Updated June 10, 2013, 2:57 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Pretty much like its Facebook brother, we need a special handler to make Google oauth work. Since at the moment we only support oauth if the account is created by mission-control-uoa (accounts-sso pluging) the class is coupled with KDE-Acounts logic.
> 
> With this fourth "AuthOperation" there is a piece of code that is copy pasted 4 times:
> uint status = qdbus_cast<uint>(props.value(QLatin1String("SASLStatus")));
> QString error = qdbus_cast<QString>(props.value(QLatin1String("SASLError")));
> QVariantMap errorDetails = qdbus_cast<QVariantMap>(props.value(QLatin1String("SASLErrorDetails")));
> authop->onSASLStatusChanged(status, error, errorDetails);
> 
> What do you want to do with it? mind that authop is a different class on each case right now (we could make all of them inherit something).
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4011542 
>   getcredentialsjob.cpp ef42b3c 
>   sasl-auth-op.cpp 9e98739 
>   x-telepathy-sso-google-operation.h PRE-CREATION 
>   x-telepathy-sso-google-operation.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/110935/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130610/e91cb22d/attachment.html>