Review Request 110929: Enforce avatar size restrictions

David Edmundson david at davidedmundson.co.uk
Mon Jun 10 09:28:56 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110929/#review34024
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On June 10, 2013, 9:26 a.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110929/
> -----------------------------------------------------------
> 
> (Updated June 10, 2013, 9:26 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Add code to Accounts KCM that will allow users to crop avatar and will scale it down to maximum size allowed by server (or to some reasonable values if server/gabble does not report avatarRequirements())
> 
> 
> This addresses bug 279112.
>     http://bugs.kde.org/show_bug.cgi?id=279112
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 6ad7d6f 
>   src/account-identity-dialog.cpp 7cf930b 
>   src/avatar-button.h 19b953e 
>   src/avatar-button.cpp 803fef8 
>   src/fetch-avatar-job.h f9841e2 
>   src/fetch-avatar-job.cpp e734ede 
>   src/kcm-telepathy-accounts.cpp e41ccb4 
> 
> Diff: http://git.reviewboard.kde.org/r/110929/diff/
> 
> 
> Testing
> -------
> 
> Took a huuuuuge image, selected a less huge part of it in the UI, clicked OK, avatar was correctly cropped and scaled down.
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130610/04dc5403/attachment.html>


More information about the KDE-Telepathy mailing list