Review Request 110870: Add Optional Accounts-SSO support to ktp-auth-handler

[David Edmundson]

> On June 7, 2013, 5:14 p.m., Daniele E. Domenichelli wrote:
> > CMakeLists.txt, lines 18-19
> > <http://git.reviewboard.kde.org/r/110870/diff/1/?file=149002#file149002line18>
> >
> >     since these are optional, perhaps use macro_optional_find_package?
> 
> Aleix Pol Gonzalez wrote:
>     I wouldn't do that. It's only use is to explicitly disable the finding from the cache.
>     
>     That said, if it was me, I'd make them REQUIRED.
> 
> David Edmundson wrote:
>     Being able to enable/disable independently would be a bad thing. AccountsQt without SignOnQt or vice versa would be really bad, so we would have to manually write our own combo of OPTION and FIND_PACKAGE.. and that's probably too much effort for the reward.
>     
>     Adding REQUIRED would be really bad as that half our distributions wouldn't be able to compile and everyone would be stuck on 0.6 forever. 
>     
>     I'm fine with this as-is.
> 
> Àlex Fiestas wrote:
>     Dropping it then.
> 
> Daniele E. Domenichelli wrote:
>     It's also useful to print a pretty output about the packages found and not found using macro_log_feature, I think it's quite useful to detect which features won't be build because some package was not found.
>     
>     Being able to enable/disable them independently would just mean that if one of the 2 libraries, HAVE_SSC would be disabled, exactly like if you had just one library installed. The only check required is "if(ACCOUNTSQT_FOUND AND SIGNONQT_FOUND)" that is already there. So I don't see any real difference, except that if you don't have the required libraries you will see it in the output.

We still get

-- Could NOT find accountsqt (missing:  ACCOUNTSQT_LIBRARY ACCOUNTSQT_INCLUDE_DIR) 
-- Could NOT find signonqt (missing:  SIGNONQT_LIBRARY SIGNONQT_INCLUDE_DIR) 

But you're right, it doesn't do that nice:

-- The following OPTIONAL packages have not been found:

 * accountsqt , AccountQt , <http://SomePlace.com>
   Support for WebAccounts

Which would be useful to allow people to actually use this.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110870/#review33908
-----------------------------------------------------------


On June 7, 2013, 6:03 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110870/
> -----------------------------------------------------------
> 
> (Updated June 7, 2013, 6:03 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Adds Accounts-SSO support to ktp-auth-handler by checking if the account has a StorageIdentifier (which we assume comes from Accounts) and X-FACEBOOK-PLATFORM mechanism exsts.
> 
> We'll probably have to implement something special for Google as well.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 6c51903 
>   cmake/modules/FindAccountsQt.cmake PRE-CREATION 
>   cmake/modules/FindSignOnQt.cmake PRE-CREATION 
>   getcredentialsjob.h PRE-CREATION 
>   getcredentialsjob.cpp PRE-CREATION 
>   sasl-auth-op.h 6e0e5ef 
>   sasl-auth-op.cpp b745234 
>   x-telepathy-sso-operation.h PRE-CREATION 
>   x-telepathy-sso-operation.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/110870/diff/
> 
> 
> Testing
> -------
> 
> Tested with and without support, it builds and works in both cases.
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130607/855c8946/attachment.html>