Review Request 111727: accounts-kcm gui code for steam plugin of libpurple

[Thomas Pfeiffer]

> On July 28, 2013, 1:53 p.m., David Edmundson wrote:
> > File Attachment: KCM (added by Dave on Daniel's behalf)
> > <http://git.reviewboard.kde.org/r/111727/#fcomment59>
> >
> >     We also have a problem with this. We probably can't ship the steam icon. Will need to think of something KDE wise. 
> >     
> >     (again this will go in the .profile file so we can deal with that separately)
> 
> Thomas Pfeiffer wrote:
>     Seems like we need to bribe an artist to make us an icon (luckily, it won't be needed in many different sizes, right?)
> 
> Daniel Cohen wrote:
>     How 'close' to the original logo are we supposed to steer towards/away from? I might be able to source an icon.

I'd say 
- close enough so that it's easily recognizable
- far away enough not to infringe on any trademark
- fitting the Oxygen theme

You might take a look at the Facebook, ICQ or GTalk icons for an idea.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111727/#review36670
-----------------------------------------------------------


On July 28, 2013, 1:52 p.m., Daniel Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111727/
> -----------------------------------------------------------
> 
> (Updated July 28, 2013, 1:52 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Gui code for accounts-kcm that gives the steam-mobile plugin of libpurple a native/shiny look. I Didn't include the https tickbox because it seems to not function.
> 
> 
> Diffs
> -----
> 
>   plugins/haze/CMakeLists.txt ebc28c6 
>   plugins/haze/haze-account-ui-plugin.cpp e618518 
>   plugins/haze/haze-steam-account.h PRE-CREATION 
>   plugins/haze/haze-steam-account.cpp PRE-CREATION 
>   plugins/haze/steam-main-options-widget.h PRE-CREATION 
>   plugins/haze/steam-main-options-widget.cpp PRE-CREATION 
>   plugins/haze/steam-main-options-widget.ui PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111727/diff/
> 
> 
> Testing
> -------
> 
> Created new account and logged in successfully.
> 
> 
> File Attachments
> ----------------
> 
> KCM (added by Dave on Daniel's behalf)
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/07/28/steam1.png
> 
> 
> Thanks,
> 
> Daniel Cohen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130728/93566319/attachment-0001.html>