Review Request 111706: Merge contacts on drag + drop

[Thomas Pfeiffer]

> On July 26, 2013, 8:02 a.m., Martin Klapetek wrote:
> > contact-list-widget.cpp, line 739
> > <http://git.reviewboard.kde.org/r/111706/diff/1/?file=173743#file173743line739>
> >
> >     I think this breaks moving contacts in between groups. Have you tried?
> 
> David Edmundson wrote:
>     It means you have to drop on a group header. Not just a contact in a group.

Since the group headers are high enough to make an easy drop target and they are the "natural" drop target to move into a group, I don't see a problem here. And I never had a problem with that behavior in Kopete.
Great feature!


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111706/#review36524
-----------------------------------------------------------


On July 26, 2013, 12:39 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111706/
> -----------------------------------------------------------
> 
> (Updated July 26, 2013, 12:39 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Merge contacts on drag + drop
> 
> 
> Diffs
> -----
> 
>   contact-list-widget.cpp 992811739f7fbe5b8fdd99dfeead654de59efe84 
> 
> Diff: http://git.reviewboard.kde.org/r/111706/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130728/b716add0/attachment.html>