Review Request 111727: accounts-kcm gui code for steam plugin of libpurple

David Edmundson david at davidedmundson.co.uk
Fri Jul 26 16:41:56 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111727/#review36557
-----------------------------------------------------------


1) Fix your diff as discussed on IRC
2) I'd like a label above Steam Guard Code to explain what it is.

- David Edmundson


On July 26, 2013, 4:30 p.m., Daniel Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111727/
> -----------------------------------------------------------
> 
> (Updated July 26, 2013, 4:30 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Gui code for accounts-kcm that gives the steam-mobile plugin of libpurple a native/shiny look. I Didn't include the https tickbox because it seems to not function.
> 
> 
> Diffs
> -----
> 
>   plugins/haze/steam-main-options-widget.ui PRE-CREATION 
>   plugins/haze/steam-main-options-widget.cpp PRE-CREATION 
>   plugins/haze/steam-main-options-widget.h PRE-CREATION 
>   plugins/haze/haze-steam-account.cpp PRE-CREATION 
>   plugins/haze/haze-steam-account.h PRE-CREATION 
>   plugins/haze/haze-account-ui-plugin.cpp e618518 
>   plugins/haze/CMakeLists.txt ebc28c6 
> 
> Diff: http://git.reviewboard.kde.org/r/111727/diff/
> 
> 
> Testing
> -------
> 
> Created new account and logged in successfully.
> 
> 
> Thanks,
> 
> Daniel Cohen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130726/18021df4/attachment.html>


More information about the KDE-Telepathy mailing list