Review Request 111682: Make TelepathyLoggerQt an optional dependency of ktp-common-internals

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111682/#review36511
-----------------------------------------------------------


This review has been submitted with commit bf4b5ff289bba6e6e252a860d50002707c048c81 by Dan Vrátil to branch master.

- Commit Hook


On July 25, 2013, 2:43 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111682/
> -----------------------------------------------------------
> 
> (Updated July 25, 2013, 2:43 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Given it's a temporary solution before we come up with some abstraction for 0.8, I think #ifdefs are fine
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt db298f2 
>   KTp/CMakeLists.txt 203ed99 
>   KTp/message-processor.h 42f8be6 
>   KTp/message-processor.cpp ea2699d 
>   KTp/message.h 982b8cf 
>   KTp/message.cpp fa9c608 
>   KTp/outgoing-message.cpp 055017e 
> 
> Diff: http://git.reviewboard.kde.org/r/111682/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130725/4683f69d/attachment-0001.html>