Review Request 111683: Make TelepathyLoggerQt an optional dependency of ktp-text-ui

[Daniele E. Domenichelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111683/#review36492
-----------------------------------------------------------


The idea and the implementation look good to me, I wonder if it is worth to move this in ktp-common-internal, in order to avoid to ifdef everything in the other packages

- Daniele E. Domenichelli


On July 25, 2013, 2:43 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111683/
> -----------------------------------------------------------
> 
> (Updated July 25, 2013, 2:43 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Because LogManager is asynchronous, #ifdef'ing it's usage would be very messy, so instead I introduced a dummy implementation which only emits fetched() signal with empty list when building without TpLoggerQt. Given it's just a temporary measure, this seems to be the least intrusive approach.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 1d16dc7 
>   lib/CMakeLists.txt 80a3eff 
>   lib/chat-widget.cpp 74cee48 
>   lib/logmanager.h 3f4a2f1 
>   lib/logmanager.cpp 6cd1aec 
>   lib/logmanager_dummy.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111683/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130725/48f7766c/attachment-0001.html>