Review Request 111685: Make TelepathyLoggerQt an optional dependency of ktp-accounts-kcm

[Daniele E. Domenichelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111685/#review36493
-----------------------------------------------------------

Ship it!



src/kcm-telepathy-accounts.cpp
<http://git.reviewboard.kde.org/r/111685/#comment26929>

    Maybe add a comment to remind that KMessageBox::createKMessageBox will not show the checkbox if the message is empty...


- Daniele E. Domenichelli


On July 25, 2013, 2:44 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111685/
> -----------------------------------------------------------
> 
> (Updated July 25, 2013, 2:44 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Almost forgot about this one :)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt fb4e50d 
>   src/kcm-telepathy-accounts.cpp 59e3d21 
> 
> Diff: http://git.reviewboard.kde.org/r/111685/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130725/4cd55a19/attachment.html>