Review Request 111501: Fix LaTeX filter

[Andrea Scarpino]

> On July 14, 2013, 3:41 p.m., Martin Klapetek wrote:
> > filters/latex/latex-filter.cpp, line 76
> > <http://git.reviewboard.kde.org/r/111501/diff/1/?file=170559#file170559line76>
> >
> >     I'm not sure about this as it references something, that is not later..well, referenced. I mean the formula should have prepended "(%1)" as well I think. This will be weird especially with longer text - "this is the formula (1) text text text text text text text text text text text text text text text text text text text text text text text text text text text text text 
> >     
> >     LaTeX"
> >     
> >     Maybe it could be even replaced with "(formula below)"?
> 
> Daniele E. Domenichelli wrote:
>     Usually you use [1], not (1) for citation, also I had something similar in the "code" plugin, so I think we could share a way to have references to the appended parts (perhaps have an link as well?)
>     Also the appended part should have the same number of the reference, or it will become confusing if you have several appended items in the same message
> 
> Thomas Pfeiffer wrote:
>     It's not citations, though. I'd compare it to those "see figure 4" references in scientific literature. There the number has to be written above/bleow the figure as well, though
> 
> Daniele E. Domenichelli wrote:
>     Agreed, but still I don't like (1), so I vote for "[1]" or "(see attachment 1)" as we could use the same for videos, code, etc. But still we need a clear way to show that "(see attachment 1)" was not written by the user, and selecting and copying that part should probably skip it, and copy the original text instead...
>     But this is actually not related to this patch, so I'd rather move this discussion on the bug tracker.
> 
> Daniele E. Domenichelli wrote:
>     Bug here: https://bugs.kde.org/show_bug.cgi?id=322392

I'd say to ship this without the reference thing (so it works again) and then wait for Daniele's suggestion to be implemented.


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111501/#review35936
-----------------------------------------------------------


On July 14, 2013, 12:05 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111501/
> -----------------------------------------------------------
> 
> (Updated July 14, 2013, 12:05 p.m.)
> 
> 
> Review request for Telepathy and Andrea Scarpino.
> 
> 
> Description
> -------
> 
> Fix LaTeX filter
> 
> Instead of trying to put the images inline we put a reference and insert the LaTeX images at the end.
> 
> The "appended message parts" aren't affected by other filters.
> 
> 
> Diffs
> -----
> 
>   filters/latex/latex-filter.cpp 4e9601f095c1a3790e719b1cbbd1f32ed75c0424 
> 
> Diff: http://git.reviewboard.kde.org/r/111501/diff/
> 
> 
> Testing
> -------
> 
> currently code renders as <img src=".... because we run before the escape filter. 
> 
> If we run after we get bugs because we escape before the LaTeX can get the original code.
> 
> This fixes both of them, and makes it clearer for larger amounts of text, as otherwise line heights get confusing.
> 
> 
> File Attachments
> ----------------
> 
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/07/14/formula.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130722/411104f7/attachment.html>