Review Request 111561: Fix the string changes in the previous commit

Martin Klapetek martin.klapetek at gmail.com
Thu Jul 18 12:59:58 UTC 2013



> On July 18, 2013, 12:03 p.m., Martin Klapetek wrote:
> > I'm not 100% sure, but shouldn't there be no spaces? ie. "xgettext:no-c-format"?
> 
> Lasse Liehu wrote:
>     The strings at lines 46-53 already use the same comment format and it works correctly there.

Ah cool, ship it then!


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111561/#review36107
-----------------------------------------------------------


On July 18, 2013, 11:58 a.m., Lasse Liehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111561/
> -----------------------------------------------------------
> 
> (Updated July 18, 2013, 11:58 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> xgettext: no-c-format is needed for them. Sorry for not realizing this earlier and also for forgetting to put the REVIEW tag to the previous commit; won't forget this time.
> 
> 
> Diffs
> -----
> 
>   config/telepathy-kded-config.cpp a5da6d7 
> 
> Diff: http://git.reviewboard.kde.org/r/111561/diff/
> 
> 
> Testing
> -------
> 
> Compilation.
> 
> 
> Thanks,
> 
> Lasse Liehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130718/7f82f033/attachment.html>


More information about the KDE-Telepathy mailing list