Review Request 111511: Wait for the accountmanager + accounts to be ready in the JoinChatRoomDialog

David Edmundson david at davidedmundson.co.uk
Mon Jul 15 14:36:39 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111511/#review35975
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On July 15, 2013, 2:09 p.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111511/
> -----------------------------------------------------------
> 
> (Updated July 15, 2013, 2:09 p.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> As the title says. This makes it much easier to use the dialog.
> 
> 
> Diffs
> -----
> 
>   KTp/Widgets/join-chat-room-dialog.h 3c99e78 
>   KTp/Widgets/join-chat-room-dialog.cpp 4c2e9bf 
> 
> Diff: http://git.reviewboard.kde.org/r/111511/diff/
> 
> 
> Testing
> -------
> 
> Still seems to be ok in ktp-contact-list
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130715/ccaf8185/attachment.html>


More information about the KDE-Telepathy mailing list