Review Request 111387: Add merge/unmerge button to contact list toolbar

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111387/#review35628
-----------------------------------------------------------



main-widget.cpp
<http://git.reviewboard.kde.org/r/111387/#comment26138>

    Pretty Headers please



main-widget.cpp
<http://git.reviewboard.kde.org/r/111387/#comment26137>

    I just wanted to say that was very clever, rather than wrapping the whole action in in lots of #ifdefs everywhere
    
    ++++



main-widget.cpp
<http://git.reviewboard.kde.org/r/111387/#comment26139>

    I want this terminology consistent throughout libkpeople usage.
    
    In the Person app we use "merge".
    
    I like "link" too.. but I want it the same.



main-widget.cpp
<http://git.reviewboard.kde.org/r/111387/#comment26140>

    Why do we need to do this? 
    Doesn't KPeople do it all internally?



main-widget.cpp
<http://git.reviewboard.kde.org/r/111387/#comment26141>

    This needs #ifdef


- David Edmundson


On July 4, 2013, 10:49 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111387/
> -----------------------------------------------------------
> 
> (Updated July 4, 2013, 10:49 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Adds KDualAction to merge contacts into a metacontact or unmerge metacontacts. It still misses couple things (eg. getting the returned job and then the uri of new created person), but it's quite complex and I'd like to get early feedback on it.
> 
> There are many combinations that the user can select, main 9 ones (0 contacts, 1 contact, n contacts in combination with 0 persons, 1 person, n persons) plus cases like "contact is a subcontact of selected person", "contact is subcontact of different person" etc.
> 
> 
> Diffs
> -----
> 
>   contact-list-widget.h 0ab5449 
>   contact-list-widget.cpp 1bdf635 
>   main-widget.h 8dab6e0 
>   main-widget.cpp b9129fa 
> 
> Diff: http://git.reviewboard.kde.org/r/111387/diff/
> 
> 
> Testing
> -------
> 
> Selecting different contact combinations properly sets the KDualAction.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130705/60deba9c/attachment.html>