Review Request 108619: Port contact list to KTp::ContactInfoDialog

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108619/#review26277
-----------------------------------------------------------

Ship it!



context-menu.cpp
<http://git.reviewboard.kde.org/r/108619/#comment20007>

    why is this a QWeakPointer?
    
    as soon as you hit the end this function this pointer will be completely lost.
    
    I realise this isn't your code.. but you touched it, you have to fix it.
    I suspect it was for the exec() problem and then someone changed it to be show() instead.. but didn't fix this code.
    



main-widget.cpp
<http://git.reviewboard.kde.org/r/108619/#comment20009>

    I suspect this will slow down startup time. 
    
    It may be best to do an upgradeContacts() inside the dialog.
    
    You don't have to fix that now, but it's worth us looking into this sort of optimisation in the future.


- David Edmundson


On Jan. 27, 2013, 4:01 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108619/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2013, 4:01 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> :-)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt ef52f01 
>   context-menu.cpp d8cad05 
>   dialogs/contact-info.h ef81d03 
>   dialogs/contact-info.cpp 1cd346a 
>   dialogs/contact-info.ui 1106fa3 
>   main-widget.cpp 31bb688 
> 
> Diff: http://git.reviewboard.kde.org/r/108619/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130127/e1a6709c/attachment.html>