Review Request 108607: Fix crash when we go offline while loading history in text-ui

David Edmundson david at davidedmundson.co.uk
Sun Jan 27 14:44:25 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108607/#review26254
-----------------------------------------------------------

Ship it!


Add a comment explaining why.

- David Edmundson


On Jan. 26, 2013, 9:41 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108607/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2013, 9:41 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> ...and fix coding style in the whole file
> 
> I use 'return' so that we don't emit fetched() with only partial list of messages.
> 
> 
> This addresses bug 313927.
>     http://bugs.kde.org/show_bug.cgi?id=313927
> 
> 
> Diffs
> -----
> 
>   lib/logmanager.cpp cc664bb 
> 
> Diff: http://git.reviewboard.kde.org/r/108607/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130127/48443b9c/attachment.html>


More information about the KDE-Telepathy mailing list