Review Request 108566: Fix dialout UI to make use of all new library code.

David Edmundson david at davidedmundson.co.uk
Thu Jan 24 10:55:14 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108566/
-----------------------------------------------------------

(Updated Jan. 24, 2013, 10:55 a.m.)


Review request for Telepathy.


Changes
-------

Rebased


Description
-------

Remove private gabble hack, instead use KTp::Contact which has it inbuilt


Use KTp::Actions for starting audio/video call


Port dialout widget to AccountsComboBox rather than old models

Also fixes loading/saving the last used accounts in the UI, using a model index isn't very reliable if the accounts change.


Diffs (updated)
-----

  src/dialout/CMakeLists.txt b547847b675ca4d3aedc684e96ea40f94381c76c 
  src/dialout/dialout-widget.h 5c201a149c1a2110832a634b850a256f8ecc9b00 
  src/dialout/dialout-widget.cpp 93b95885f53ccf4494a7cf6a4a691dd4a4f3ba7a 
  src/dialout/dialout-widget.ui 8c40e74edd16f31eb542d9d4a1a6ede83f2698f8 

Diff: http://git.reviewboard.kde.org/r/108566/diff/


Testing
-------

Opened dial out UI. Check accounts were filtered, checked buttons were enabled when typing a correct contact address.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130124/bd6870de/attachment.html>


More information about the KDE-Telepathy mailing list