Review Request 108564: Use KTp::ContactFactory in KTp::ContactGridDialog

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108564/
-----------------------------------------------------------

Review request for Telepathy.


Description
-------

Using Tp::ContactFactory causes crash in KTp::ContactsListModel::data(), because cast to KTp::Contact fails and then we dereference a null pointer.

Question of the day: could we add something like Q_ASSERT_X(contact.isNull(), "Cast failed", "Did you forget to use Ktp::ContactFactory again?") to data() to make it easier to spot the real problem? It took me good 15 minutes to figure out where the null pointer comes from and why the cast fails.


Diffs
-----

  KTp/Widgets/contact-grid-dialog.cpp a23014a 

Diff: http://git.reviewboard.kde.org/r/108564/diff/


Testing
-------


Thanks,

Dan Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130123/f7ba1224/attachment.html>