Review Request 108500: Show typing icon in tabbar and window title

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108500/#review25821
-----------------------------------------------------------

Ship it!


Fix the first comment before shipping.


app/chat-window.cpp
<http://git.reviewboard.kde.org/r/108500/#comment19723>

    if you switch to a tab, and the remote contact is typing, this is lost.
    
    We have a remoteChatState() so it should be easy.



app/chat-window.cpp
<http://git.reviewboard.kde.org/r/108500/#comment19721>

    We have an issue about to occur.
    
    1) pretty sure I used document-edit in my recent patch to ChannelContactlModel
    
    Not saying your is wrong, simply that we should make them both the same. (so we can edit my one if that's better)
    
    2) in a different icon set this might make no sense.
    
    We have a list of icons we want to request,  we should add this to the list.



app/chat-window.cpp
<http://git.reviewboard.kde.org/r/108500/#comment19722>

    I don't like ChatWidget having a method called icon() and then logic elsewhere that puts in different icons.
    
    _but_ I prefer this approach here.
    
    So this comment is to remind me to delete ChatWidget::icon() and replace it with remotePresence() and we can do all the logic here.


- David Edmundson


On Jan. 20, 2013, 3:10 a.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108500/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2013, 3:10 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Based on what Martin suggested in the bug report, I extended the behaviour by also showing an icon when there's an unread message. The icons work as following:
> 
> Tab icon:
> When there is an unread message in a tab, show "unread message" icon. When there are no unread messages and someone in the chat is typing, show "typing" icon. Otherwise show presence icon. The reasoning is that you are probably more interested in the fact that there is an unread message, than that someone is typing.
> 
> Window icon:
> When there is an unread message in ANY tab, show "unread message" icon. When there are no unread messages in any tab and someone in CURRENT tab is typing, show "typing" icon. Otherwise show presence icon of current tab. The reasoning again is that you are most interested in the fact that somewhere there is an unread message. The "typing" icon is shown only for current tab, because it might get confusing why the window is indicating "typing" when the current user is not typing.
> 
> 
> This addresses bug 311859.
>     http://bugs.kde.org/show_bug.cgi?id=311859
> 
> 
> Diffs
> -----
> 
>   app/chat-window.h 5a90c91 
>   app/chat-window.cpp b48f148 
> 
> Diff: http://git.reviewboard.kde.org/r/108500/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130120/f0fcc3d2/attachment.html>