Review Request 108502: Fix "Edit Identity" button in KCM

Dan Vrátil dvratil at redhat.com
Sun Jan 20 04:10:34 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108502/
-----------------------------------------------------------

Review request for Telepathy.


Description
-------

1) Fix enabling/disabling of the "Edit Identity" button when switching between "local XMPP" listview and the accounts listview. The problem was that both, accounts listview and the "local XMPP" listview were emitting "onCurrentChanged" signal. Usually accounts listview delivered the signal earlier and cancelled the selection in the "local XMPP" listview, therefore you had to sometimes click twice and the "Edit Identity" button was not enabled/disabled correctly.

2) Automatically enable/disable the "Edit Identity" button when current account is connected/disconnected.


This addresses bug 291653.
    http://bugs.kde.org/show_bug.cgi?id=291653


Diffs
-----

  src/kcm-telepathy-accounts.h d4802db 
  src/kcm-telepathy-accounts.cpp 9ca5949 

Diff: http://git.reviewboard.kde.org/r/108502/diff/


Testing
-------


Thanks,

Dan Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130120/8dba33de/attachment-0001.html>


More information about the KDE-Telepathy mailing list