Review Request 108498: KTp::ContactInfoDialog

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108498/
-----------------------------------------------------------

(Updated Jan. 20, 2013, 3 a.m.)


Review request for Telepathy.


Description
-------

KTp::ContactInfoDialog is a dialog very similar to the contact info dialog in contact list, but it displays more detailed information, like full name, homepage, birthday etc.

I moved the dialog to ktp-common-internals, so that it can be shared between contactlist and kded module - see bug https://bugs.kde.org/show_bug.cgi?id=298764.

The dialog also supports editing mode (see screenshots), when you open the dialog with "yourself" (that's contact == account->connection->selfContact). This feature could be used in KCM for instance. Unfortunately when I was almost finished, I found out, that TelepathyQt4 does not have API for editing contact information (RAGE!), so the editing code is disabled for now. Upstream patch is already waiting for review: https://bugs.freedesktop.org/show_bug.cgi?id=59609


Diffs
-----

  KTp/CMakeLists.txt 10c17bf 
  KTp/contact-info-dialog.h PRE-CREATION 
  KTp/contact-info-dialog.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/108498/diff/


Testing
-------


File Attachments (updated)
----------------


  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/contactdialog.png

  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/contactdialog-edit.png


Thanks,

Dan Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130120/b07977d2/attachment.html>