Review Request 108401: Make it possible to start conversations from the Quick Chat plasmoid: Backend-Side
Commit Hook
null at kde.org
Tue Jan 15 00:39:31 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108401/#review25552
-----------------------------------------------------------
This review has been submitted with commit 837984454c9d2b87424dd49ff560101be78762f5 by Aleix Pol to branch master.
- Commit Hook
On Jan. 15, 2013, 12:07 a.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108401/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2013, 12:07 a.m.)
>
>
> Review request for Telepathy and David Edmundson.
>
>
> Description
> -------
>
> I've wanted to use this plasmoid for longtime, I fear that the reason why I'm not using it yet is because I can't start chats from there. The plan is that this will improve the situation, to some extent.
>
> The important part about the patch is that the root element is refactored into a grid that can have different elements. Now I added a button with a contactlist that probably should go, but eventually i'd like to have non-conversation buttons so that one can pin contacts.
>
> ** This is the library part after the split. You can follow the discussion in https://git.reviewboard.kde.org/r/107811/ **
>
>
> Diffs
> -----
>
> KTp/CMakeLists.txt 12d0654
> KTp/Declarative/CMakeLists.txt 17fea5a
> KTp/Declarative/contact-pin.h PRE-CREATION
> KTp/Declarative/contact-pin.cpp PRE-CREATION
> KTp/Declarative/conversation-target.h cce2138
> KTp/Declarative/conversation-target.cpp 99d2176
> KTp/Declarative/conversation.h 4b277eb
> KTp/Declarative/conversation.cpp afd58e3
> KTp/Declarative/conversations-model.h c0d0128
> KTp/Declarative/conversations-model.cpp fe564ac
> KTp/Declarative/messages-model.h 4ad2ff8
> KTp/Declarative/messages-model.cpp 0553f0b
> KTp/Declarative/pinned-contacts-model.h PRE-CREATION
> KTp/Declarative/pinned-contacts-model.cpp PRE-CREATION
> KTp/Declarative/qml-plugins.cpp d1dfbea
> KTp/Declarative/telepathy-text-observer.h 4f2a028
> KTp/Declarative/telepathy-text-observer.cpp 98dfced
> KTp/Models/contacts-model.h e352569
> KTp/ktp-metatypes.h PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/108401/diff/
>
>
> Testing
> -------
>
> Tested with the chat plasmoid
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130115/083bb119/attachment.html>
More information about the KDE-Telepathy
mailing list