Review Request 108401: Make it possible to start conversations from the Quick Chat plasmoid: Backend-Side

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108401/#review25424
-----------------------------------------------------------


Looks good, but I'll wait for David's review. Also please fix the coding style - we use the kdelibs one, simply move the pointer signs to the variable name (Var* p -> Var *p) and put spaces around operators (i==0 -> i == 0). Also there are some whitespace leftovers.


KTp/Declarative/conversation-target.cpp
<http://git.reviewboard.kde.org/r/108401/#comment19442>

    Remove the presence arg since it's not needed



KTp/Declarative/pinned-contacts-model.cpp
<http://git.reviewboard.kde.org/r/108401/#comment19443>

    qDebug -> kDebug



KTp/Declarative/pinned-contacts-model.cpp
<http://git.reviewboard.kde.org/r/108401/#comment19444>

    qDebug -> kDebug



KTp/Declarative/pinned-contacts-model.cpp
<http://git.reviewboard.kde.org/r/108401/#comment19445>

    I think this would be better named as pinOperationFinished(..)



KTp/Declarative/pinned-contacts-model.cpp
<http://git.reviewboard.kde.org/r/108401/#comment19446>

    The presence can also be Unset, Uknown and Error, you should check for those too



KTp/Declarative/pinned-contacts-model.cpp
<http://git.reviewboard.kde.org/r/108401/#comment19447>

    Parenthesis



KTp/Declarative/pinned-contacts-model.cpp
<http://git.reviewboard.kde.org/r/108401/#comment19448>

    parenthesis



KTp/Declarative/qml-plugins.cpp
<http://git.reviewboard.kde.org/r/108401/#comment19449>

    whitespace


- Martin Klapetek


On Jan. 14, 2013, 4:02 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108401/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2013, 4:02 a.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> I've wanted to use this plasmoid for longtime, I fear that the reason why I'm not using it yet is because I can't start chats from there. The plan is that this will improve the situation, to some extent.
> 
> The important part about the patch is that the root element is refactored into a grid that can have different elements. Now I added a button with a contactlist that probably should go, but eventually i'd like to have non-conversation buttons so that one can pin contacts.
> 
> ** This is the library part after the split. You can follow the discussion in https://git.reviewboard.kde.org/r/107811/ **
> 
> 
> Diffs
> -----
> 
>   KTp/CMakeLists.txt 12d0654 
>   KTp/Declarative/CMakeLists.txt 17fea5a 
>   KTp/Declarative/contact-pin.h PRE-CREATION 
>   KTp/Declarative/contact-pin.cpp PRE-CREATION 
>   KTp/Declarative/conversation-target.h cce2138 
>   KTp/Declarative/conversation-target.cpp 99d2176 
>   KTp/Declarative/conversation.h 4b277eb 
>   KTp/Declarative/conversation.cpp afd58e3 
>   KTp/Declarative/conversations-model.h c0d0128 
>   KTp/Declarative/conversations-model.cpp fe564ac 
>   KTp/Declarative/messages-model.h 4ad2ff8 
>   KTp/Declarative/messages-model.cpp 0553f0b 
>   KTp/Declarative/pinned-contacts-model.h PRE-CREATION 
>   KTp/Declarative/pinned-contacts-model.cpp PRE-CREATION 
>   KTp/Declarative/qml-plugins.cpp d1dfbea 
>   KTp/Declarative/telepathy-text-observer.h 4f2a028 
>   KTp/Declarative/telepathy-text-observer.cpp 98dfced 
>   KTp/Models/contacts-model.h e352569 
>   KTp/ktp-metatypes.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/108401/diff/
> 
> 
> Testing
> -------
> 
> Tested with the chat plasmoid
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130114/a29b9aee/attachment-0001.html>