Review Request 109209: Move version information into CMakeLists.txt

[Daniele E. Domenichelli]

> On Feb. 28, 2013, 3:37 p.m., Aleix Pol Gonzalez wrote:
> > I like it, I've wanted to do that in many projects...
> > 
> > version.h should be provided by ktp-common-internals, no? This way you only put it once, for real...
> 
> David Edmundson wrote:
>     The problem with that is if we run contact list 0.5.2 against ktp-common-internals 0.5.3 it will say the wrong thing.

Anyway note for the future: it could be a good thing to know both the component version and the ktp-common-internals version that the component is using. (i.e. runnning ktp-text-ui --version could show both)


- Daniele E.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109209/#review28267
-----------------------------------------------------------


On Feb. 28, 2013, 3:30 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109209/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2013, 3:30 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Move version information into CMakeLists.txt
> 
> This will make releases a bit easier
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 1ba261c2f3c90616a6a60200cc1ba397a846e90a 
>   main.cpp d7d0febabfedf06e31003bb0c1e19760cf335ea7 
>   version.h.in PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109209/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130228/9d2606f2/attachment-0001.html>