Review Request 109209: Move version information into CMakeLists.txt

[David Edmundson]

> On Feb. 28, 2013, 4:30 p.m., Aleix Pol Gonzalez wrote:
> > Well, then you probably want to make sure they're all the same version anyway.
> > 
> > ktp-common-internals is not ensuring binary compatibility, and it's fine, IMHO.
> > 
> > But that's your call, you're the maintainer.
> > 
> > I fail to see, why it's better to have the version moved from main.cpp -> CMakeLists.txt then

it's better because every release I have to update all of them, and I want to go around moving all of them to the same place (right at the top of CMakeLists.txt) the auth-handler and some others are already here and they were quite easy to do. Having to grep about is not.

A public version number in common-internals would be easier still, but last time this came up (I think I was for it) it was rejected as being a bad idea. 
We do ensure compatibility throughout a 0.5.x series, so there is still scope for it to be out of sync without everything crashing.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109209/#review28271
-----------------------------------------------------------


On Feb. 28, 2013, 3:30 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109209/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2013, 3:30 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Move version information into CMakeLists.txt
> 
> This will make releases a bit easier
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 1ba261c2f3c90616a6a60200cc1ba397a846e90a 
>   main.cpp d7d0febabfedf06e31003bb0c1e19760cf335ea7 
>   version.h.in PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109209/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130228/398dbd6d/attachment.html>