Review Request 109202: Message sending shortcut is now configurable

[Roman Nazarenko]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109202/
-----------------------------------------------------------

(Updated Feb. 28, 2013, 5:03 p.m.)


Review request for Telepathy.


Changes
-------

Checked coding style. 
Added global actions searching routine. 
Added send-message action to text editor class scope. 
Added proper processing for Key_Return if it's not a message sending shortcut.


Description
-------

The patch is a mess. QTextEdit handles Key_Return, we need to save Key_Return from passing to QTextEdit, but we need to know KAction shortcut. And that shortcut is stored in ChatWindow, which is located far away in the QObject parenting tree.
This patch allows user to configure custom shortcut, but standard shortcut (Key_Return) is still working. I have no idea how to disable it without types casting hell.


This addresses bug https://bugs.kde.org/show_bug.cgi?id=308894.
    http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=308894


Diffs (updated)
-----

  app/chat-window.h 018e91a 
  app/chat-window.cpp c79e3aa 
  lib/chat-text-edit.h 4279ce5 
  lib/chat-text-edit.cpp 19fdb38 
  lib/chat-widget.h 2c85f3b 
  lib/chat-widget.cpp e7adc5a 

Diff: http://git.reviewboard.kde.org/r/109202/diff/


Testing
-------


Thanks,

Roman Nazarenko

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130228/9ce47431/attachment.html>