Review Request 109202: Message sending shortcut is now configurable
Roman Nazarenko
me at jtalk.me
Thu Feb 28 13:51:45 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109202/
-----------------------------------------------------------
Review request for Telepathy.
Description
-------
The patch is a mess. QTextEdit handles Key_Return, we need to save Key_Return from passing to QTextEdit, but we need to know KAction shortcut. And that shortcut is stored in ChatWindow, which is located far away in the QObject parenting tree.
This patch allows user to configure custom shortcut, but standard shortcut (Key_Return) is still working. I have no idea how to disable it without types casting hell.
This addresses bug https://bugs.kde.org/show_bug.cgi?id=308894.
http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=308894
Diffs
-----
app/chat-window.h 018e91a
app/chat-window.cpp c79e3aa
lib/chat-text-edit.h 4279ce5
lib/chat-text-edit.cpp 19fdb38
lib/chat-widget.h 2c85f3b
lib/chat-widget.cpp e7adc5a
Diff: http://git.reviewboard.kde.org/r/109202/diff/
Testing
-------
Thanks,
Roman Nazarenko
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130228/a55d004b/attachment.html>
More information about the KDE-Telepathy
mailing list