Review Request 109188: Moved actions and groups creation into separate functions in main widget

Roman Nazarenko me at jtalk.me
Thu Feb 28 07:19:14 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109188/
-----------------------------------------------------------

(Updated Feb. 28, 2013, 7:19 a.m.)


Review request for Telepathy.


Changes
-------

Removed group setting up function and struct.
Made  separate function for checkable actions creation.


Description
-------

There was 6 identical routines creating actions for "Contact List Type" and "Shown contacts" menus. 
I made one universal routine to do that, one routine to build those two groups and one struct as an options tuple.


Diffs (updated)
-----

  main-widget.h be7004d 
  main-widget.cpp 39442de 

Diff: http://git.reviewboard.kde.org/r/109188/diff/


Testing
-------

Tried to toggle all those actions in both standard and global menus.
Have not tested "Shown contacts" since I have no blocked ones.


Thanks,

Roman Nazarenko

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130228/e9023fc3/attachment.html>


More information about the KDE-Telepathy mailing list