Review Request 109182: Make Message store sender and MessageProcessor take arbitrary filters

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109182/#review28149
-----------------------------------------------------------



KTp/message.cpp
<http://git.reviewboard.kde.org/r/109182/#comment21053>

    Discussed outside reviewboard with Lasath in a video chat.
    
    Plan is to make
    
    KTp::ContactPtr sender() //just like Tp::Message this can be null
    QString senderName()
    QString senderId()
    
    actual method calls, that way our message kinda matches Tp::RecievedMessage() which is cool
    
    
    We can then update MessagesModel to store this rather than keeping an extra custom class. Code Removal ++
    
    We remove the appendFilter and removeFilter (because it's broken) instead HighlightFilter gets manually called from the text-ui without the message processor.
    
    
    
    


- David Edmundson


On Feb. 26, 2013, 5:08 p.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109182/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2013, 5:08 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This is the accompanying patch to https://git.reviewboard.kde.org/r/109181/.
> 
> It makes KTp::Messages store sender details as properties (to be used to send the notification). 
> 
> It also adds two methods to KTp::MessageProcessor to append/remove filters. I did this as a quick hack to allow me to test the NotifyFilter. I think we'll have to make KTp::MessageFilter a non singleton class and have it implicitly share the loaded plugins list between instances.
> 
> 
> This addresses bug 315790.
>     http://bugs.kde.org/show_bug.cgi?id=315790
> 
> 
> Diffs
> -----
> 
>   KTp/message-processor.cpp 82b11eb 
>   KTp/message.cpp 7be60e0 
>   KTp/message-processor.h 7cd4d87 
> 
> Diff: http://git.reviewboard.kde.org/r/109182/diff/
> 
> 
> Testing
> -------
> 
> Same as the other patch.
> 
> 
> Thanks,
> 
> Lasath Fernando
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130227/903489e9/attachment-0001.html>