Review Request 109188: Moved actions and groups creation into separate functions in main widget

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109188/#review28206
-----------------------------------------------------------



main-widget.h
<http://git.reviewboard.kde.org/r/109188/#comment21083>

    Making a struct that mimics all the properties of a KAction doesn't make a lot of sense to me. We're duplicating data, data duplication leads to problems.
    



main-widget.h
<http://git.reviewboard.kde.org/r/109188/#comment21074>

    confugures -> configures
    
    
    if we convert this into 
    
    KAction * createAction(const QString& text, QObject *signalReceiver, const char *slot, bool isChecked);
    
    which is the same as it is now, but calls "new KAction(this)" at the start
    
    
    It's basically the same as the ctor of ActionOptions but keeping logic grouped together



main-widget.h
<http://git.reviewboard.kde.org/r/109188/#comment21084>

    this then becomes QList<KAction*> and gets simplified.


- David Edmundson


On Feb. 27, 2013, 10:29 a.m., Roman Nazarenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109188/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2013, 10:29 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> There was 6 identical routines creating actions for "Contact List Type" and "Shown contacts" menus. 
> I made one universal routine to do that, one routine to build those two groups and one struct as an options tuple.
> 
> 
> Diffs
> -----
> 
>   main-widget.h be7004d 
>   main-widget.cpp 39442de 
> 
> Diff: http://git.reviewboard.kde.org/r/109188/diff/
> 
> 
> Testing
> -------
> 
> Tried to toggle all those actions in both standard and global menus.
> Have not tested "Shown contacts" since I have no blocked ones.
> 
> 
> Thanks,
> 
> Roman Nazarenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130227/8c048093/attachment.html>