Review Request 109158: Rebase/update Youtube filter

[Nikita Skovoroda]

> On Feb. 26, 2013, 6:33 p.m., Nikita Skovoroda wrote:
> > I don't like something about it, needs some checks.
> > I'll do them a bit later today.

You are checking for .contains(), but using the whole value.

The «v» parameter in «http://youtube.com/?v=idf32"></iframe><div>…</div><iframe%20src="» contains QRegExp validId(QLatin1String("[a-zA-Z0-9_-]+")).


- Nikita


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109158/#review28160
-----------------------------------------------------------


On Feb. 25, 2013, 9:31 p.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109158/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2013, 9:31 p.m.)
> 
> 
> Review request for Telepathy, David Edmundson and Nikita Skovoroda.
> 
> 
> Description
> -------
> 
> Since there was little hope of getting that giant demotivating patch merged all in one go, I thought I may as well submit little patches as I have time.
> 
> I cherry picked the commit that added the Youtube filter, and then changed the code to make it work with the current MessageProcessor.
> 
> 
> Diffs
> -----
> 
>   filters/CMakeLists.txt 2f88157 
>   filters/youtube/CMakeLists.txt PRE-CREATION 
>   filters/youtube/ktptextui_message_filter_youtube.desktop PRE-CREATION 
>   filters/youtube/youtube-filter.h PRE-CREATION 
>   filters/youtube/youtube-filter.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109158/diff/
> 
> 
> Testing
> -------
> 
> Sent myself cool videos. ;-)
> 
> 
> Thanks,
> 
> Lasath Fernando
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130226/7a15dbd3/attachment-0001.html>