Review Request 109181: Implement filter to handle notifications

[Aleix Pol Gonzalez]

> On Feb. 26, 2013, 5:05 p.m., Aleix Pol Gonzalez wrote:
> > lib/chat-widget.cpp, line 655
> > <http://git.reviewboard.kde.org/r/109181/diff/1/?file=115998#file115998line655>
> >
> >     assert false???
> >     you could just remove the method altogether, no?
> 
> Lasath Fernando wrote:
>     should I? I didn't know where it was used/connected to signals. 
>     
>     If it were private, I would have ditched it in a heartbeat. But since this is 'protected' in a public library, I didn't know how exactly to proceed. (Do we deprecate it?)

ktp-common-internals is not maintaining public API so far, so yes.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109181/#review28145
-----------------------------------------------------------


On Feb. 26, 2013, 5:14 p.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109181/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2013, 5:14 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> While I'm quite content with the state of this patch, I'm not satisfied with the corresponding patch to ktp-common-internals (which I'll upload shortly).
> 
> There are 2 great advantages to having this filter than ChatWidget::notifyAboutIncomingMessage():
> 
> 1. It makes ChatWidget smaller and makes me that much happier. (Seriously, that class is way too HUUUUUGE and has waaaayyy too many responsibilities).
> 
> 2. Since it works off a KTp::Message rather than a Tp::RecievedMessage, it sends the correct notification based on whether the "highlight" property is set.
> 
> 
> This addresses bug 315790.
>     http://bugs.kde.org/show_bug.cgi?id=315790
> 
> 
> Diffs
> -----
> 
>   lib/notify-filter.h PRE-CREATION 
>   lib/notify-filter.cpp PRE-CREATION 
>   lib/chat-widget.cpp e7adc5a 
>   lib/CMakeLists.txt 5c4741d 
>   lib/chat-widget.h 2c85f3b 
> 
> Diff: http://git.reviewboard.kde.org/r/109181/diff/
> 
> 
> Testing
> -------
> 
> Sent messages to myself, and got the correct notifications.
> 
> 
> Thanks,
> 
> Lasath Fernando
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130226/2fe84a64/attachment.html>