Review Request 109181: Implement filter to handle notifications

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109181/#review28145
-----------------------------------------------------------



filters/highlight/highlight-filter.h
<http://git.reviewboard.kde.org/r/109181/#comment21050>

    unneeded change



filters/highlight/highlight-filter.cpp
<http://git.reviewboard.kde.org/r/109181/#comment21049>

    unneeded change



lib/chat-widget.cpp
<http://git.reviewboard.kde.org/r/109181/#comment21051>

    assert false???
    you could just remove the method altogether, no?


To me it looks nice that you're splitting it into a different class. Mostly thinking that active/plasmoids might be able to take advantage of this work easily.

There are a lot of unrelated changes, though. You should minimize that. (not that they're incorrect).

- Aleix Pol Gonzalez


On Feb. 26, 2013, 4:56 p.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109181/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2013, 4:56 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> While I'm quite content with the state of this patch, I'm not satisfied with the corresponding patch to ktp-common-internals (which I'll upload shortly).
> 
> There are 2 great advantages to having this filter than ChatWidget::notifyAboutIncomingMessage():
> 
> 1. It makes ChatWidget smaller and makes me that much happier. (Seriously, that class is way too HUUUUUGE and has waaaayyy too many responsibilities).
> 
> 2. Since it works off a KTp::Message rather than a Tp::RecievedMessage, it sends the correct notification based on whether the "highlight" property is set.
> 
> 
> This addresses bug 315790.
>     http://bugs.kde.org/show_bug.cgi?id=315790
> 
> 
> Diffs
> -----
> 
>   lib/notify-filter.h PRE-CREATION 
>   lib/notify-filter.cpp PRE-CREATION 
>   lib/chat-widget.h 2c85f3b 
>   lib/chat-widget.cpp e7adc5a 
>   lib/CMakeLists.txt 5c4741d 
>   filters/youtube/ktptextui_message_filter_youtube.desktop 82a9d03 
>   filters/highlight/ktptextui_message_filter_highlight.desktop 59553eb 
>   filters/highlight/highlight-filter.h 0725e06 
>   filters/highlight/highlight-filter.cpp f58a0bb 
> 
> Diff: http://git.reviewboard.kde.org/r/109181/diff/
> 
> 
> Testing
> -------
> 
> Sent messages to myself, and got the correct notifications.
> 
> 
> Thanks,
> 
> Lasath Fernando
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130226/feeb5026/attachment.html>