Review Request 109165: Create a QObject interface to KTp::Actions

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109165/#review28137
-----------------------------------------------------------


I like the principle. 

This sort of conflicts with what I started here https://git.reviewboard.kde.org/r/108895/ where I put startTextChat into the TpController/AccountManager wrapper QObject class. I put in a startTextChat and intended to have what you've just done here. If we go with my approach, I'll copy and paste all the code you've just done here. I'll do an update tonight.



- David Edmundson


On Feb. 26, 2013, 3:26 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109165/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2013, 3:26 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> QML can't deal with namespaces, provide a way to.
> 
> It probably should be developed further into providing feedback on the requests, but...
> http://www.sureiscute.com/images/50360e401d41c87726000130.jpg
> 
> On the other hand, with this we can drop files to a delegate and it will send the file (i wanted to upload the patch but RB is not accepting the patch for some reason... I'll try again tomorrow)
> 
> 
> Diffs
> -----
> 
>   KTp/Declarative/CMakeLists.txt 3865c13 
>   KTp/Declarative/declarative-ktp-actions.h PRE-CREATION 
>   KTp/Declarative/declarative-ktp-actions.cpp PRE-CREATION 
>   KTp/Declarative/qml-plugins.cpp 7bf1c41 
> 
> Diff: http://git.reviewboard.kde.org/r/109165/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130226/984a8782/attachment.html>