Review Request 109161: Update Highlight filter

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109161/#review28103
-----------------------------------------------------------


I think it's a good start, I'd like to see configurable set of highliting strings at some point...I think that could be another JJ.


filters/highlight/highlight-filter.h
<http://git.reviewboard.kde.org/r/109161/#comment21024>

    Put the variable name here (to the QVariantList). Makes it easier to read/understand.



filters/highlight/highlight-filter.cpp
<http://git.reviewboard.kde.org/r/109161/#comment21026>

    Var name here too. Also the d(new..) is usually on a new line.


- Martin Klapetek


On Feb. 26, 2013, 3:52 a.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109161/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2013, 3:52 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This one was fairly straight forward. Just had to fix some build issues and update the metadata file.
> 
> 
> Diffs
> -----
> 
>   filters/CMakeLists.txt ac25a17 
>   filters/highlight/CMakeLists.txt PRE-CREATION 
>   filters/highlight/highlight-filter.h PRE-CREATION 
>   filters/highlight/highlight-filter.cpp PRE-CREATION 
>   filters/highlight/ktptextui_message_filter_highlight.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109161/diff/
> 
> 
> Testing
> -------
> 
> Wrote my name. Felt like in primary school.
> 
> 
> Thanks,
> 
> Lasath Fernando
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130226/ee061020/attachment.html>