Review Request 109158: Rebase/update Youtube filter
David Edmundson
david at davidedmundson.co.uk
Mon Feb 25 21:42:03 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109158/#review28080
-----------------------------------------------------------
Ship it!
\o/
filters/youtube/ktptextui_message_filter_youtube.desktop
<http://git.reviewboard.kde.org/r/109158/#comment21006>
it'll -> it will
embedd-> embed
preivew -> preview
lasath -> eye test
- David Edmundson
On Feb. 25, 2013, 9:31 p.m., Lasath Fernando wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109158/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2013, 9:31 p.m.)
>
>
> Review request for Telepathy, David Edmundson and Nikita Skovoroda.
>
>
> Description
> -------
>
> Since there was little hope of getting that giant demotivating patch merged all in one go, I thought I may as well submit little patches as I have time.
>
> I cherry picked the commit that added the Youtube filter, and then changed the code to make it work with the current MessageProcessor.
>
>
> Diffs
> -----
>
> filters/CMakeLists.txt 2f88157
> filters/youtube/CMakeLists.txt PRE-CREATION
> filters/youtube/ktptextui_message_filter_youtube.desktop PRE-CREATION
> filters/youtube/youtube-filter.h PRE-CREATION
> filters/youtube/youtube-filter.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/109158/diff/
>
>
> Testing
> -------
>
> Sent myself cool videos. ;-)
>
>
> Thanks,
>
> Lasath Fernando
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130225/4c9c62a1/attachment.html>
More information about the KDE-Telepathy
mailing list