Review Request 109142: KDE global menu support over DBus added

Roman Nazarenko me at jtalk.me
Mon Feb 25 17:23:18 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109142/
-----------------------------------------------------------

(Updated Feb. 25, 2013, 5:23 p.m.)


Review request for Telepathy.


Changes
-------

Added m_ prefix to class properties.
New properties are new initialized properly.
Made View menu items shorter and clear.


Description
-------

Added global menu support.
Menu is not appearing in main window, so it's tiny look is not broken.
I also moved actions for menu from MainWidget constructor to class private scope, so they can be used from any method. 


This addresses bug https://bugs.kde.org/show_bug.cgi?id=292396.
    http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=292396


Diffs (updated)
-----

  main-widget.h d14a669 
  main-widget.cpp a3ea666 

Diff: http://git.reviewboard.kde.org/r/109142/diff/


Testing
-------


Thanks,

Roman Nazarenko

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130225/1b066489/attachment.html>


More information about the KDE-Telepathy mailing list