Review Request 109139: Added notifications settings into main menu

[Roman Nazarenko]

> On Feb. 25, 2013, 12:12 p.m., Dan Vrátil wrote:
> > CMakeLists.txt, line 74
> > <http://git.reviewboard.kde.org/r/109139/diff/3/?file=115313#file115313line74>
> >
> >     Nah, there must be a variable defined by a CMake package that you can use
> 
> Roman Nazarenko wrote:
>     I saw, but I'm kinda newbie and I don't really know how do I do that. If anybody will push me in the right direction, I'll fix CMakeLists more properly.
> 
> Alin M Elena wrote:
>     you need to replace -lknotify with this variable ${KDE4_KNOTIFYCONFIG_LIBS} or something like that.
>     
>     Alin
> 
> Alin M Elena wrote:
>     just to be complete... http://techbase.kde.org/Development/CMake/Addons_for_KDE

Thank you, I updated diff with this variable.


- Roman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109139/#review27999
-----------------------------------------------------------


On Feb. 25, 2013, 1:01 p.m., Roman Nazarenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109139/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2013, 1:01 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Added global notifications settings to main menu via KNotifyConfigWidget.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=313381.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=313381
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 9712de2 
>   contact-list-widget.cpp 2e8dcb8 
> 
> Diff: http://git.reviewboard.kde.org/r/109139/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Roman Nazarenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130225/034403a7/attachment.html>