Review Request 109139: Added notifications settings into main menu

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109139/#review27999
-----------------------------------------------------------


Nice, I like this! 


CMakeLists.txt
<http://git.reviewboard.kde.org/r/109139/#comment20967>

    Nah, there must be a variable defined by a CMake package that you can use



contact-list-widget.cpp
<http://git.reviewboard.kde.org/r/109139/#comment20968>

    I think it's OK.


- Dan Vrátil


On Feb. 25, 2013, 12:54 p.m., Roman Nazarenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109139/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2013, 12:54 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Added global notifications settings to main menu via KNotifyConfigWidget.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=313381.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=313381
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 9712de2 
>   contact-list-widget.cpp 2e8dcb8 
> 
> Diff: http://git.reviewboard.kde.org/r/109139/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Roman Nazarenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130225/15448eed/attachment.html>