Review Request 109134: Chat plasmoid: Improve placement of the dialog
Aleix Pol Gonzalez
aleixpol at gmail.com
Mon Feb 25 04:32:53 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109134/
-----------------------------------------------------------
(Updated Feb. 25, 2013, 4:32 a.m.)
Review request for Telepathy.
Description
-------
Place the dialog by the plasmoid instead of 0,0 in case the button's delegate hasn't been set up yet or there was a problem finding out the position.
It's good because a dialog at 0,0 looks really odd.
Diffs (updated)
-----
chat/org.kde.ktp-chat/contents/ui/ConversationDelegate.qml b82f34e
Diff: http://git.reviewboard.kde.org/r/109134/diff/
Testing
-------
just start a conversation from a pinned button and you'll see it looks funny...
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130225/389b84dc/attachment.html>
More information about the KDE-Telepathy
mailing list