Review Request 109089: Improve behavior on smaller sizes
David Edmundson
david at davidedmundson.co.uk
Fri Feb 22 18:27:05 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109089/#review27895
-----------------------------------------------------------
Ship it!
Fix the +3 :)
- David Edmundson
On Feb. 22, 2013, 3:53 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109089/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2013, 3:53 p.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> We had a bug regarding the sizes of the main view. I found out it all was caused by the minimum sizes calculation.
>
> This fixes this bug by giving a better minimum size instead of just implying that we have 1 size and it's the current one. Furthermore, this makes it possible to have items that are thinner than a square, which makes the whole plasmoid a bit more flexible.
>
>
> This addresses bug 315550.
> http://bugs.kde.org/show_bug.cgi?id=315550
>
>
> Diffs
> -----
>
> chat/org.kde.ktp-chat/contents/ui/main.qml 3a9b74d
>
> Diff: http://git.reviewboard.kde.org/r/109089/diff/
>
>
> Testing
> -------
>
> I played with it for a while with 2 contacts, it felt much better and no warnings in the console.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130222/c372599d/attachment.html>
More information about the KDE-Telepathy
mailing list