Review Request 109072: Add a property to the ConversationModel to tell how many unread messages we have
David Edmundson
david at davidedmundson.co.uk
Thu Feb 21 09:50:58 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109072/#review27823
-----------------------------------------------------------
Ship it!
I'm curious as to what behavioural change this has. What does Plasma do when the status changes?
KTp/Declarative/conversations-model.h
<http://git.reviewboard.kde.org/r/109072/#comment20861>
consider totalUnreadCount
to make it different from the unreadCount of a MessagesModel object
Not forcing it though, up to you.
- David Edmundson
On Feb. 21, 2013, 2:38 a.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109072/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2013, 2:38 a.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Nothing much further.
> A property that counts unread messages and notifies about when it changes
>
> I want it to be able to tell the plasmoid state.
>
> See frontend side: https://git.reviewboard.kde.org/r/109073/
>
>
> This addresses bug 296928.
> http://bugs.kde.org/show_bug.cgi?id=296928
>
>
> Diffs
> -----
>
> KTp/Declarative/conversations-model.h 5cf626c
> KTp/Declarative/conversations-model.cpp c013241
>
> Diff: http://git.reviewboard.kde.org/r/109072/diff/
>
>
> Testing
> -------
>
> simple UI testing
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130221/27a5b2f9/attachment.html>
More information about the KDE-Telepathy
mailing list