Review Request 109070: Move the ContactPin instance where it belongs

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109070/#review27805
-----------------------------------------------------------

Ship it!


Much more readable. Nice.

- David Edmundson


On Feb. 21, 2013, 1:18 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109070/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2013, 1:18 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> ContactPin is a class that keeps track of the pin state against a contact.
> 
> Don't forward properties and signals, put it where it should be. It's a small simplification in the code.
> 
> 
> Diffs
> -----
> 
>   chat/org.kde.ktp-chat/contents/ui/ChatWidget.qml 37c6991 
>   chat/org.kde.ktp-chat/contents/ui/ConversationDelegate.qml fc5592a 
> 
> Diff: http://git.reviewboard.kde.org/r/109070/diff/
> 
> 
> Testing
> -------
> 
> nothing seemed to stop working
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130221/7b8637c1/attachment.html>