Review Request 109051: Cache all the conversation in the ListView

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109051/#review27767
-----------------------------------------------------------

Ship it!



chat/org.kde.ktp-chat/contents/ui/ChatWidget.qml
<http://git.reviewboard.kde.org/r/109051/#comment20809>

    Comment why we're doing this (maybe with that Qt bug report number if it's still relevant)


- David Edmundson


On Feb. 20, 2013, 2:45 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109051/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2013, 2:45 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> I think the patch is quite self-explanatory. Keep all the delegates in memory while showing. It could be a problem if the conversation grows _a lot_ but it has to grow a lot.
> 
> Possible ways to solve it:
> - limit the log lines that we'll be displaying. We're talking about a plasmoid anyway. If the user wants to read the log, he'll use ktp-log-viewer.
> - set interactive to false. Then we can scroll as much we want, but not with the scrollbar
> - buy a better aleix
> 
> 
> Diffs
> -----
> 
>   chat/org.kde.ktp-chat/contents/ui/ChatWidget.qml 2d13dba 
> 
> Diff: http://git.reviewboard.kde.org/r/109051/diff/
> 
> 
> Testing
> -------
> 
> You don't really want to know... It mostly involves that file: http://paste.kde.org/676436/
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130220/c6103a8e/attachment.html>